On Fri, Oct 25, 2019 at 8:47 AM Michael Paquier <[email protected]> wrote: > > Hi Amit, > > On Fri, Oct 25, 2019 at 02:24:50AM +0000, Amit Kapila wrote: > > Make the order of the header file includes consistent in non-backend > > modules. > > > > Similar to commit 7e735035f2, this commit makes the order of header file > > inclusion consistent for non-backend modules. > > > > In passing, fix the case where we were using angle brackets (<>) for the > > local module includes instead of quotes (""). > > locust has just reported a build failure here: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=locust&dt=2019-10-25%2002%3A58%3A55 >
Yeah, I have noticed that and working on it. > And the cause is visibly this portion of the commit: > --- a/src/interfaces/ecpg/pgtypeslib/dt_common.c > +++ b/src/interfaces/ecpg/pgtypeslib/dt_common.c > @@ -7,9 +7,9 @@ > #include <math.h> > > #include "common/string.h" > -#include "pgtypeslib_extern.h" > #include "dt.h" > #include "pgtypes_timestamp.h" > +#include "pgtypeslib_extern.h" Right, but trying to see why it hasn't failed on other machines and in my local build. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
