Remove incorrect assertion for INSERT in logical replication's publisher On the publisher, it was assumed that an INSERT change cannot happen for a relation with no replica identity. However this is true only for a change that needs references to old rows, aka UPDATE or DELETE, so trying to use logical replication with a relation that has no replica identity led to an assertion failure in the publisher when issuing an INSERT. This commit removes the incorrect assertion, and adds more regression tests to provide coverage for relations without replica identity.
Reported-by: Neha Sharma Author: Dilip Kumar, Michael Paquier Reviewed-by: Andres Freund Discussion: https://postgr.es/m/caniytqsl1hb8_km08qd32svrqnumxljeogo014o7vzymgoh...@mail.gmail.com Backpatch-through: 10 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7c21a964ef8a3b51f1fe0571054343ac0941008e Modified Files -------------- src/backend/replication/logical/proto.c | 4 ---- src/test/subscription/t/001_rep_changes.pl | 16 ++++++++++++++-- 2 files changed, 14 insertions(+), 6 deletions(-)
