On Sat, Feb 8, 2020 at 10:04 AM Tom Lane <[email protected]> wrote: > > Fujii Masao <[email protected]> writes: > > On Sat, Feb 8, 2020 at 4:25 AM Tom Lane <[email protected]> wrote: > >> AFAICS, this patch has caused an ABI break in v12. Do we really > >> believe that no extension references the values of the ScanOptions > >> enum? > > > Yes, you are right. Some extensions may depend on it. > > It's better not to add new ScanOption not to break ABI. > > I think it's okay to add a new value of ScanOption; what you can't > do is change the codes assigned to the existing values. So I'd > just revert those code changes and give SO_TYPE_TIDSCAN a value > that's out-of-order.
So you are thinking to apply something like the attached to both master and v12? That sounds better to me. Regards, -- Fujii Masao
dont_break_abi_v2.patch
Description: Binary data
