On Sun, Feb 9, 2020 at 8:05 PM Tom Lane <[email protected]> wrote: > > I wrote: > > Alexander Korotkov <[email protected]> writes: > >> Fix page modification outside of critical section in GIN > > > I happened to notice, while reviewing stuff for the release notes, > > that this patch does not do what the commit message says. The > > previous code modified the pd_prune_xid of the "dBuffer" page, > > but now it's modifying the pd_prune_xid of the "lBuffer" page. > > Is that actually correct? > > Since we're rapidly approaching the wrap deadline for this week's > releases, I took it upon myself to review this code more carefully, > and concluded that indeed it isn't correct. I pushed a fix that > moves the GinPageSetDeleteXid call again.
Sorry for delayed response. Yes, my fix for oversight contain oversight itself. I confirm the fix you've committed is correct. Thank you! ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
