Another issue I just noticed is that src/tools/pginclude/cpluspluscheck complains thusly:
./src/include/access/nbtree.h: In function 'void
BTreeTupleSetPosting(IndexTupleData*, int, int)':
./src/include/access/nbtree.h:384: warning: comparison between signed and
unsigned integer expressions
I suppose this can be silenced with an appropriate cast, and doing so
would seem like a good idea.
regards, tom lane
