Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > On 3/26/20 9:50 AM, Tom Lane wrote: >> Why is jacana doing it differently?
> longfin is also running it (first) here > https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=longfin&dt=2020-03-26%2014%3A39%3A51&stg=ssl_passphrase_callback-check Oh, I missed that. Isn't that pretty duplicative of the testmodules-install phase? > I don't think this belongs in installcheck, we should add > 'NO_INSTALLCHECK = 1' to the Makefile. Why? The other src/test/modules/ modules with TAP tests do not specify that, with the exception of commit_ts which has a solid doesnt-work-in-the-default-configuration excuse. regards, tom lane