On Tue, Oct 8, 2019 at 2:23 PM Peter Eisentraut <pe...@eisentraut.org> wrote: > > Remove some code for old unsupported versions of MSVC > > As of d9dd406fe281d22d5238d3c26a7182543c711e74, we require MSVC 2013, > which means _MSC_VER >= 1800. This means that conditionals about > older versions of _MSC_VER can be removed or simplified. >
I wonder why this has not been backpatched to v12? I am talking mainly about changes in IsoLocaleName made by this function. The reason why I started looking at this commit is that I wanted to backpatch some fix [1] in function IsoLocaleName and it seems to be different in 12 and 13 for no reason. It is not a big deal but I was curious to know if there is a reason we can't have this part of code the same in 12 and 13. That will at least allow easier backpatch in the future. I understand it is not a part of code that is changed on a regular basis but still, it might be good to keep the code consistent. [1] - https://www.postgresql.org/message-id/CAHzhFSFoJEWezR96um4-rg5W6m2Rj9Ud2CNZvV4NWc9tXV7aXQ%40mail.gmail.com -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
