Fix misuse of table_index_fetch_tuple_check(). Commit 0d861bbb, which added deduplication to nbtree, had _bt_check_unique() pass a TID to table_index_fetch_tuple_check() that isn't safe to mutate. table_index_fetch_tuple_check()'s tid argument is modified when the TID in question is not the latest visible tuple in a hot chain, though this wasn't documented.
To fix, go back to using a local copy of the TID in _bt_check_unique(), and update comments above table_index_fetch_tuple_check(). Backpatch: 13-, where B-Tree deduplication was introduced. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/10f1ab2cb8bea3c6741a78f6dc19a5c91c0a34e1 Modified Files -------------- src/backend/access/nbtree/nbtinsert.c | 3 ++- src/backend/access/table/tableam.c | 4 ++++ src/include/access/tableam.h | 4 +++- 3 files changed, 9 insertions(+), 2 deletions(-)
