Restore replication protocol's duplicate command tags I removed the duplicate command tags for START_REPLICATION inadvertently in commit 07082b08cc5d, but the replication protocol requires them. The fact that the replication protocol was broken was not noticed because all our test cases use an optimized code path that exits early, failing to verify that the behavior is correct for non-optimized cases. Put them back.
Also document this protocol quirk. Add a test case that shows the failure. It might still succeed even without the patch when run on a fast enough server, but it suffices to show the bug in enough cases that it would be noticed in buildfarm. Author: Álvaro Herrera <[email protected]> Reported-by: Henry Hinze <[email protected]> Reviewed-by: Petr Jelínek <[email protected]> Discussion: https://postgr.es/m/[email protected] Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/72e43fc313e93c95704c574bcf98805805668063 Modified Files -------------- doc/src/sgml/protocol.sgml | 8 +++-- src/backend/replication/logical/worker.c | 1 - src/backend/replication/walsender.c | 3 +- src/test/subscription/t/100_bugs.pl | 55 +++++++++++++++++++++++++++++++- 4 files changed, 61 insertions(+), 6 deletions(-)
