On Mon, Oct 26, 2020 at 09:29:46PM -0400, Tom Lane wrote: > Hm, I suspect what Alvaro meant was > > #define PageIsVerified(page, blkno) \ > - PageIsVerifiedExtended(page, blkno, \ > + PageIsVerifiedExtended((page), (blkno), \ > > But IMV that's not necessary: if the argument parsed as a single > function/macro argument before, it still will do so. The places > where you have to be careful to add parentheses are where the > macro argument is used as part of a larger expression that is > not just a function/macro argument.
Thanks. I really thought that this remark was for the bit-flag argument for readability reasons, not the two others as we don't do that in other places (varbit.h, bufpage.h, timestamp.h, brin_page.h, etc.). Perhaps I just missed the point. -- Michael
signature.asc
Description: PGP signature
