On Thu, Nov 12, 2020 at 05:29:00PM -0300, Álvaro Herrera wrote:
> On 2020-Nov-12, Bruce Momjian wrote:
>
> > doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
> >
> > These files are in compiled directories and install directories.
>
> I think this patch is wrong, because in the install tree the files are in
> the server/ subdir. It should read:
>
> The <acronym>OID</acronym>s of the built-in data types are defined in
> the file <filename>include/catalog/pg_type_d.h</filename> in the
> compiled source directory, and in
> <filename>include/server/catalog/pg_type_d.h</filename> in the install
> directory.
>
> That said, if the user is doing a VPATH build, then "compiled source
> directory" is a confusing way to say "the build directory", and I don't
> think it's an important location anyway, first because it's really a
> throwaway directory, and second it's not even there in a packaged
> installation; users just care about the *installed* file, don't they?
> So I suggest to rip that part out, and leave just:
>
> The <acronym>OID</acronym>s of the built-in data types are defined in
> the file <filename>include/server/catalog/pg_type_d.h</filename> in the
> install directory.
OK, how is this followup patch?
--
Bruce Momjian <[email protected]> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 73c6a6ea4d..9d4b6ab4a8 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -3666,8 +3666,8 @@ Oid PQftype(const PGresult *res,
You can query the system table <literal>pg_type</literal> to
obtain the names and properties of the various data types. The
<acronym>OID</acronym>s of the built-in data types are defined
- in the file <filename>include/catalog/pg_type_d.h</filename>
- in the compiled source directory and install directory.
+ in the file <filename>include/server/catalog/pg_type_d.h</filename>
+ in the install directory.
</para>
</listitem>
</varlistentry>
