Re: pgsql: Move SHA2 routines to a new generic API layer for crypto hashes

[Fujii Masao]

On 2020/12/02 10:41, Michael Paquier wrote:

Move SHA2 routines to a new generic API layer for crypto hashes

Thanks for improving this!
I got the following compiler failure. ISTM that the variable "status"
in both pg_cryptohash_update() and pg_cryptohash_final() needs
to be initialized with 0. Patch attached. Thought?

cryptohash_openssl.c: In function ‘pg_cryptohash_update’:
cryptohash_openssl.c:144:5: error: ‘status’ may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
  if (status <= 0)
     ^
cryptohash_openssl.c: In function ‘pg_cryptohash_final’:
cryptohash_openssl.c:179:5: error: ‘status’ may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
  if (status <= 0)
     ^
cc1: all warnings being treated as errors
make[2]: *** [cryptohash_openssl.o] Error 1
<builtin>: recipe for target 'cryptohash_openssl.o' failed

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

diff --git a/src/common/cryptohash_openssl.c b/src/common/cryptohash_openssl.c
index 8e2c69b48b..33f17cac33 100644
--- a/src/common/cryptohash_openssl.c
+++ b/src/common/cryptohash_openssl.c
@@ -119,7 +119,7 @@ pg_cryptohash_init(pg_cryptohash_ctx *ctx)
 int
 pg_cryptohash_update(pg_cryptohash_ctx *ctx, const uint8 *data, size_t len)
 {
-       int                     status;
+       int                     status = 0;
 
        if (ctx == NULL)
                return 0;
@@ -154,7 +154,7 @@ pg_cryptohash_update(pg_cryptohash_ctx *ctx, const uint8 
*data, size_t len)
 int
 pg_cryptohash_final(pg_cryptohash_ctx *ctx, uint8 *dest)
 {
-       int                     status;
+       int                     status = 0;
 
        if (ctx == NULL)
                return 0;