Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that the latter necessarily referred to an update and not a tuple lock; but that's wrong, because SELECT FOR UPDATE can use precisely that combination, as evidenced by the amcheck test case added here.
Remove the Assert(), and also patch amcheck's verify_heapam.c to not complain if the combination is found. Also, out of overabundance of caution, update (across all branches) README.tuplock to be more explicit about this. Author: Julien Rouhaud <rjuju...@gmail.com> Reviewed-by: Mahendra Singh Thalor <mahi6...@gmail.com> Reviewed-by: Dilip Kumar <dilipbal...@gmail.com> Discussion: https://postgr.es/m/20210124061758.GA11756@nol Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/28f4b61083b2a5b2bd1b7859d7cb2c6cfcb2b964 Modified Files -------------- src/backend/access/heap/README.tuplock | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
