On 23.02.21 08:23, Thomas Munro wrote:
On Tue, Feb 23, 2021 at 7:03 PM Peter Eisentraut <[email protected]> wrote:
On 22.02.21 12:28, Thomas Munro wrote:
pg_collation_actual_version() -> pg_collation_current_version().
The new name seems a bit more natural.
Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com
I don't find where this change was discussed in that thread. I
specifically chose that name to indicate, "not the current version in
the database, but the version the OS thinks it should be". I think the
rename loses that distinction.
I understood "actual" to be a way of contrasting with
pg_collation.collversion, which we dropped. Without that, the meaning
of a more typical function name with "current" seemed clearer to me,
and "actual" seemed excessively emphatic. There isn't a concept of a
single "current version in the database" anymore, there's just the set
of relevant versions that were current when each index was built.
Happy to revert the name change if you hate it though, and sorry I
didn't CC you on the thread.
Seeing that explanation, I think that's even more of a reason to avoid
the name "current" and use something strikingly different.
In any case, this function name has been around for some years now and
renaming it just for taste reasons seems unnecessary.
