On 2021-Mar-15, Tom Lane wrote:

> Alvaro Herrera <alvhe...@alvh.no-ip.org> writes:
> > Implement pipeline mode in libpq
> 
> So jacana and fairywren are unhappy about this, and the failure reports
> are totally uninformative:

Yeah.  This is the main clue:

> Mar 15 21:14:41 # Looks like you planned 8 tests but ran 15.
> Mar 15 21:14:41 # Looks like you failed 7 tests of 15 run.

We called the program seven additional times with empty string, so the
split is emitting extra results that are empty strings.

> I suspect that the "tests" output is including \r\n newlines
> and the "split" operation is not handling that right.

That seems the right guess.  We already use split(/\s+/) in other
scripts, particularly the Windows build ones, so that seems the correct
fix.

Pushed that fix.

-- 
Álvaro Herrera       Valdivia, Chile
"I dream about dreams about dreams", sang the nightingale
under the pale moon (Sandman)


Reply via email to