Improve PQtrace() output format

Transform the PQtrace output format from its ancient (and mostly
useless) byte-level output format to a logical-message-level output,
making it much more usable.  This implementation allows the printing
code to be written (as it indeed was) by looking at the protocol
documentation, which gives more confidence that the three (docs, trace
code and actual code) actually match.

Author: 岩田 彩 (Aya Iwata) <[email protected]>
Reviewed-by: 綱川 貴之 (Takayuki Tsunakawa) <[email protected]>
Reviewed-by: Kirk Jamison <[email protected]>
Reviewed-by: Kyotaro Horiguchi <[email protected]>
Reviewed-by: Tom Lane <[email protected]>
Reviewed-by: 黒田 隼人 (Hayato Kuroda) <[email protected]>
Reviewed-by: "Nagaura, Ryohei" <[email protected]>
Reviewed-by: Ryo Matsumura <[email protected]>
Reviewed-by: Greg Nancarrow <[email protected]>
Reviewed-by: Jim Doty <[email protected]>
Reviewed-by: Álvaro Herrera <[email protected]>
Discussion: 
https://postgr.es/m/71E660EB361DF14299875B198D4CE5423DE3FBA4@g01jpexmbkw25

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/198b3716dba68544b55cb97bd120738a86d5df2d

Modified Files
--------------
doc/src/sgml/libpq.sgml             |  42 ++-
src/interfaces/libpq/Makefile       |   1 +
src/interfaces/libpq/exports.txt    |   1 +
src/interfaces/libpq/fe-connect.c   |  21 --
src/interfaces/libpq/fe-exec.c      |   4 -
src/interfaces/libpq/fe-misc.c      |  66 +---
src/interfaces/libpq/fe-protocol3.c |  13 +
src/interfaces/libpq/fe-trace.c     | 714 ++++++++++++++++++++++++++++++++++++
src/interfaces/libpq/libpq-fe.h     |  17 +-
src/interfaces/libpq/libpq-int.h    |   7 +
10 files changed, 804 insertions(+), 82 deletions(-)

Reply via email to