On Mon, May 17, 2021 at 08:57:55PM -0400, Tom Lane wrote: > Michael Paquier <[email protected]> writes: >> One thing that's changing in this patch is that testtablespace would >> be created even if the input directory does not exist when using >> --make-testtablespace-dir. > > Yeah, I do not see a reason for there to be a connection. It's not > pg_regress' job to decide whether the testtablespace directory is > needed or not.
Fine by me. I don't think that's a big deal either way. >> Worth noting that snprintf() is used twice instead of once to build >> the tablespace path string. > > Yeah. I considered making a global variable so that there'd be > just one instance of that, but didn't think it amounted to less > mess in the end. No problem from me here either. >> The Windows part works correctly. > > Thanks for testing! I'll push this after the release is tagged. Thanks! -- Michael
signature.asc
Description: PGP signature
