On 06/09/2021 11:50, Amit Langote wrote:
Quite late but to I was looking at this and noticed this comment:
+ /*
+ * Direct modifications cannot be re-evaluated by EvalPlanQual, so
+ * don't bother preparing the FDW. There can ForeignScan nodes in the
+ * EvalPlanQual subtree, but ExecForeignScan should never be called.
+ */
The 2nd sentence seems to be missing a "be" between "can" and
"ForeignScan". Also, does it mean the following?
"There can be ForeignScan nodes in the EvalPlanQual plan subtree, but
ExecForeignScan should never be called on them [during EvalPlanQual]."
I've attached a patch that changes the text like that.
Applied, thanks!
- Heikki
