Fix null-pointer crash in postgres_fdw's conversion_error_callback. Commit c7b7311f6 adjusted conversion_error_callback to always use information from the query's rangetable, to avoid doing catalog lookups in an already-failed transaction. However, as a result of the utterly inadequate documentation for make_tuple_from_result_row, I failed to realize that fsstate could be NULL in some contexts. That led to a crash if we got a conversion error in such a context. Fix by falling back to the previous coding when fsstate is NULL. Improve the commentary, too.
Per report from Andrey Borodin. Back-patch to 9.6, like the previous patch. Discussion: https://postgr.es/m/[email protected] Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2288973744e8bd4715d1daaaf2cd1d9b534aa1bf Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 3 + contrib/postgres_fdw/postgres_fdw.c | 108 +++++++++++++++++-------- contrib/postgres_fdw/sql/postgres_fdw.sql | 1 + 3 files changed, 77 insertions(+), 35 deletions(-)
