On 10/8/21 11:41 AM, Andrew Dunstan wrote: > On 10/1/21 6:34 PM, Andres Freund wrote: >> Reference test binary using TESTDIR in 001_libpq_pipeline.pl. >> >> The previous approach didn't really work on windows, due to the PATH >> separator >> being ';' not ':'. Instead of making the PATH change more complicated, >> reference the binary using the TESTDIR environment. >> >> Reported-By: Andres Freund <[email protected]> >> Suggested-By: Andrew Dunstan <[email protected]> >> Discussion: >> https://postgr.es/m/[email protected] >> Backpatch: 14-, where the test was introduced. >> > I don't think any of us were thinking very clearly about this. Of > course, MSVC doesn't build executables in $TESTDIR. If we want to pick > up the executable from where it's built we'll need a little help from > vcregress.pl. I haven't tested it but What I have in mind is something > like the attached. > >
Confirmed that this makes the test pass. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
