On Thu, Nov 25, 2021 at 11:02 PM Tom Lane <[email protected]> wrote: > Robert Haas <[email protected]> writes: > > On Wed, Nov 24, 2021 at 8:01 PM Andres Freund <[email protected]> wrote: > >> Pushed the obvious fix for that. Somehow thought I'd seen more compile > >> failure > >> than the one WAL_DEBUG... > > > Hmm, thanks. I guess i put too much trust in the compiler. > > My approach to such patches is always "in grep we trust, all others > pay cash". Even without #ifdef issues, you are highly likely to > miss comments that need to be updated.
Right. I didn't rely completely on grep and did spend a lot of time looking through the code. But sometimes my eyes glaze over and I get sloppy after too much time working on one thing, and this seems to have been one of those times. Fortunately, it seems to have been only a minor oversight. -- Robert Haas EDB: http://www.enterprisedb.com
