Remove assertion for replication origins in PREPARE TRANSACTION When using replication origins, pg_replication_origin_xact_setup() is an optional choice to be able to set a LSN and a timestamp to mark the origin, which would be additionally added to WAL for transaction commits or aborts (including 2PC transactions). An assertion in the code path of PREPARE TRANSACTION assumed that this data should always be set, so it would trigger when using replication origins without setting up an origin LSN. Some tests are added to cover more this kind of scenario.
Oversight in commit 1eb6d65. Per discussion with Amit Kapila and Masahiko Sawada. Discussion: https://postgr.es/m/ybbbfnsvmm5ni...@paquier.xyz Backpatch-through: 11 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8abb6c27ec7538a4975544896c35e2f9a73a9f30 Modified Files -------------- contrib/test_decoding/expected/replorigin.out | 76 +++++++++++++++++++++++++++ contrib/test_decoding/sql/replorigin.sql | 32 +++++++++++ src/backend/access/transam/twophase.c | 1 - 3 files changed, 108 insertions(+), 1 deletion(-)
