Correct comment and some documentation about REPLICA_IDENTITY_INDEX

catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a
dropped index is equivalent to REPLICA_IDENTITY_DEFAULT.  The code tells
a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING.

The behavior exists since the introduction of replica identities, and
fe7fd4e even added tests for this case but I somewhat forgot to fix this
comment.

While on it, this commit reorganizes the documentation about replica
identities on the ALTER TABLE page, and a note is added about the case
of dropped indexes with REPLICA_IDENTITY_INDEX.

Author: Michael Paquier, Wei Wang
Reviewed-by: Euler Taveira
Discussion: 
https://postgr.es/m/os3pr01mb6275464ad0a681a0793f56879e...@os3pr01mb6275.jpnprd01.prod.outlook.com
Backpatch-through: 10

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1a0ef5e2cc63797feec1bbbf2ca89906fed76bfb

Modified Files
--------------
doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------
src/include/catalog/pg_class.h    |  2 +-
2 files changed, 44 insertions(+), 9 deletions(-)

Reply via email to