List offending databases in pg_upgrade datallowconn check The check for datallowconn being properly set on all databases in the old cluster errored out on the first instance, rather than report the set of problematic databases. This adds reporting to a textfile like how many other checks are performed. While there, also add a comment to the function as per how other checks are commented.
This check won't catch if template1 isn't allowing connections, since that's used for connecting in the first place. That error remains as it is today: connection to server on socket ".." failed: FATAL: database "template1" is not currently accepting connections Author: Jeevan Ladhe <[email protected]> Reviewed-by: Suraj Kharage <[email protected]> Reviewed-by: Justin Pryzby <[email protected]> Discussion: https://postgr.es/m/CAOgcT0McABqF_iFFQuuRf9is+gmYMsmUu_SWNikyr=2vgyp...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/26ebb0e28032283f99bf985fb47ea3d19fbaf91a Modified Files -------------- src/bin/pg_upgrade/check.c | 41 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 38 insertions(+), 3 deletions(-)
