Always pfree strings returned by GetDatabasePath Several places didn't do it, and in many cases it didn't matter because it would be a small allocation in a short-lived context; but other places may accumulate a few (for example, in CreateDatabaseUsingFileCopy, one per tablespace). In most databases this is highly unlikely to be very serious either, but it seems better to make the code consistent in case there's future copy-and-paste.
The only case of actual concern seems to be the aforementioned routine, which is new with commit 9c08aea6a309, so there's no need to backpatch. As pointed out by Coverity. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0bd56172b2871e94c0d7115ffbf430308317ac49 Modified Files -------------- src/backend/commands/dbcommands.c | 13 +++++++++++++ src/backend/utils/init/postinit.c | 1 + 2 files changed, 14 insertions(+)
