On Wed, 27 Jul 2022 at 17:29, Alexander Korotkov <akorot...@postgresql.org> wrote: > src/backend/utils/sort/tuplesort.c | 78 ++++++++++++++++----------------------
I was wondering about the following comment that this commit added: +/* + * Write a stored tuple onto tape.tuple. Unless the slab allocator is + * used, after writing the tuple, pfree() the out-of-line data (not the + * SortTuple struct!), and increase state->availMem by the amount of + * memory space thereby released. + */ static void writetuple(Tuplesortstate *state, LogicalTape *tape, SortTuple *stup) LogicalTable has no field named 'tuple' so I'm thinking the "tape.tuple" is a mistake? If so, maybe the comment should be: /* * Write 'stup' out onto 'tape' and, unless using the slab allocator, pfree stup's * tuple and adjust the memory accounting accordingly. */ David
