Fix alter_table.sql test case to test what it claims to. The stanza "SET STORAGE may need to add a TOAST table" does not test what it's supposed to, and hasn't done so since we added the ability to store constant column default values as metadata. We need to use a non-constant default to get the expected table rewrite to actually happen.
Fix that, and add the missing checks that would have exposed the problem to begin with. Noted while reviewing a patch that made changes in this test case. Back-patch to v11 where the problem came in. Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/294a2199a331ff719e0d0fe70fd2b6200689eb16 Modified Files -------------- src/test/regress/expected/alter_table.out | 30 ++++++++++++++++++++++-------- src/test/regress/sql/alter_table.sql | 11 +++++++---- 2 files changed, 29 insertions(+), 12 deletions(-)
