Hi, On 2023-02-12 16:25:28 -0500, Tom Lane wrote: > Andres Freund <[email protected]> writes: > > On February 12, 2023 1:11:08 PM PST, Tom Lane <[email protected]> wrote: > >> I don't think -Werror helps any though; it's a matter of whether the > >> cfbot is paying attention to headerscheck's exit status ... > > > Thomas fixed that part a while ago, but it'll just return 0 if it just is a > > warning... > > Hmm, but why'd the buildfarm complain then? ... oh, because it checks > for nonempty output as well as nonzero exit status.
Right. Obviously that approach could be re-implemented for CI, but givent that it additionally is somewhat required to make use of headerscheck/cpluspluscheck locally, it feels better to solve it in headerscheck. And the easiest way for that seems to be -Werror? Greetings, Andres Freund
