Fix memory leak and inefficiency in CREATE DATABASE ... STRATEGY WAL_LOG RelationCopyStorageUsingBuffer() did not free the strategies used to access the source / target relation. They memory was released at the end of the transaction, but when using a template database with a lot of relations, the temporary leak can become big prohibitively big.
RelationCopyStorageUsingBuffer() acquired the buffer for the target relation with RBM_NORMAL, therefore requiring a read of a block guaranteed to be zero. Use RBM_ZERO_AND_LOCK instead. Reviewed-by: Robert Haas <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch: 15-, where STRATEGY WAL_LOG was introduced Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/560bb56c6eba5da7917e67783d46f0d5ca30e89a Modified Files -------------- src/backend/storage/buffer/bufmgr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
