bufmgr: Fix undefined behaviour with, unrealistically, large temp_buffers Quoting Melanie: > Since if buffer is INT_MAX, then the -(buffer + 1) version invokes > undefined behavior while the -buffer - 1 version doesn't.
All other places were already using the correct version. I (Andres), copied the code into more places in a patch. Melanie caught it in review, but to prevent more people from copying the bad code, fix it. Even if it is a theoretical issue. We really ought to wrap these accesses in a helper function... As this is a theoretical issue, don't backpatch. Reported-by: Melanie Plageman <[email protected]> Discussion: https://postgr.es/m/caakru_aw2sx_lwtwhgfnqypbrunmlfe9pd6-ioppkh92xh0...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/558cf803876874c55d637a1e87417fa1c670efe1 Modified Files -------------- src/backend/storage/buffer/localbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
