Hi, On 2023-04-05 19:19:48 -0400, Tom Lane wrote: > Andres Freund <[email protected]> writes: > > Don't initialize page in {vm,fsm}_extend(), not needed > > Various buildfarm members are complaining about under-braced > initializations added by this commit. > > visibilitymap.c: In function \342\200\230vm_extend\342\200\231: > visibilitymap.c:625:2: warning: missing braces around initializer > [-Wmissing-braces] > PGAlignedBlock pg = {0}; > ^ > visibilitymap.c:625:2: warning: (near initialization for > \342\200\230pg.data\342\200\231) [-Wmissing-braces] > > freespace.c: In function \342\200\230fsm_extend\342\200\231: > freespace.c:611:2: warning: missing braces around initializer > [-Wmissing-braces] > PGAlignedBlock pg = {0}; > ^ > freespace.c:611:2: warning: (near initialization for > \342\200\230pg.data\342\200\231) [-Wmissing-braces] > > This is from buri, similar from curculio, dragonet, idiacanthus, > xenodermus, etc
I really don't see the point of placating old compilers for things like this. It's just inflicting pain on ourselves without any reward. Just to be clear: I didn't knowingly trigger the warning. Either way, an upcoming commit will implement vm_extend() / fsm_extend() with generic code, then the warning will be gone. Greetings, Andres Freund
