Andrew Dunstan <and...@dunslane.net> writes:
> Stylistic nitpick: It's not necessary to have 2 evals here:

> +   skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
> +       (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= 
> '0.98' });

> just say "eval { require IO::Pty; return $IPC::Run::VERSION >= '0.98'; }"

What I was wondering about was if it's safe to depend on the VERSION
being fully numeric.  Can't we write "use IPC::Run 0.98;" and let
some other code manage the version comparison?

                        regards, tom lane


Reply via email to