Refactor routine to find single log content pattern in TAP tests The same routine to check if a specific pattern can be found in the server logs was copied over four different test scripts. This refactors the whole to use a single routine located in PostgreSQL::Test::Cluster, named log_contains, to grab the contents of the server logs and check for a specific pattern.
On HEAD, the code previously used assumed that slurp_file() could not handle an undefined offset, setting it to zero, but slurp_file() does do an extra fseek() before retrieving the log contents only if an offset is defined. In two places, the test was retrieving the full log contents with slurp_file() after calling substr() to apply an offset, ignoring that slurp_file() would be able to handle that. Backpatch all the way down to ease the introduction of new tests that could rely on the new routine. Author: Vignesh C Reviewed-by: Andrew Dunstan, Dagfinn Ilmari Mannsåker, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u...@mail.gmail.com Backpatch-through: 11 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ced4cc30d5decf504c7b2f2fd4b80eda24d72e1e Modified Files -------------- src/test/perl/PostgresNode.pm | 15 +++++++++++++++ src/test/recovery/t/033_replay_tsp_drops.pl | 14 ++------------ 2 files changed, 17 insertions(+), 12 deletions(-)
