Rename StartBackgroundWorker() to BackgroundWorkerMain(). The comment claimed that it is "called from postmaster", but it is actually called in the child process, pretty early in the process initialization. I guess you could interpret "called from postmaster" to mean that, but it seems wrong to me. Rename the function to be consistent with other functions with similar role.
Reviewed-by: Thomas Munro Discussion: https://www.postgresql.org/message-id/[email protected] Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/637109d13ab2684aa7ad4e893137e7487b5e8490 Modified Files -------------- src/backend/postmaster/bgworker.c | 7 ++----- src/backend/postmaster/postmaster.c | 4 ++-- src/include/postmaster/bgworker_internals.h | 4 ++-- 3 files changed, 6 insertions(+), 9 deletions(-)
