Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in practice. Add some commentary defining the expectations for NULL values of string variables, in hopes of forestalling future additions of more such bugs.
Xing Guo, Aleksander Alekseev, Tom Lane Discussion: https://postgr.es/m/cacpmh+aydx5yuppaagzvwc1d8zfol4jod-uyfdnnsa1z0es...@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/47c0f00cf90f58402c4fa9d9d605ca2fe8132687 Modified Files -------------- src/backend/utils/misc/guc.c | 12 ++++++++++-- src/include/utils/guc_tables.h | 10 ++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-)
