Fix handling of errors in libpq pipelines The logic to keep the libpq command queue in sync with queries that have been processed had a bug when errors were returned for reasons other than problems in queries -- for example, when a connection is lost. We incorrectly consumed an element from the command queue every time, but this is wrong and can lead to the queue becoming empty ahead of time, leading to later malfunction: PQgetResult would return nothing, potentially causing the calling application to enter a busy loop.
Fix by making the SYNC queue element a barrier that can only be consumed when a SYNC message is received. Backpatch to 14. Reported by: Иван Трофимов (Ivan Trofimov) <i.trofi...@yandex.ru> Discussion: https://postgr.es/m/17948-fcace7557e449...@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f89681816793d79584296c58960f790e6e073459 Modified Files -------------- src/interfaces/libpq/fe-exec.c | 63 ++++++++++++++++++++++++------------- src/interfaces/libpq/fe-protocol3.c | 16 ++++------ src/interfaces/libpq/libpq-int.h | 3 +- 3 files changed, 49 insertions(+), 33 deletions(-)
