Fix incorrect error message for IDENTIFY_SYSTEM Commit 5a991ef8692e accidentally reversed the order of the tuples and fields parameters, making the error message incorrectly refer to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and 3 or 4 fields. Fix by changing the order of the parameters. This also adds a comment describing why we check for < 3 when postgres since 9.4 has been sending 4 fields.
Backpatch all the way since the bug is almost a decade old. Author: Tomonari Katsumata <t.katsumata1...@gmail.com> Reviewed-by: Tom Lane <t...@sss.pgh.pa.us> Bug: #18224 Backpatch-through: v12 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/376eaa45a2b8a2aed45b26e5fc889d2cb70ec6a7 Modified Files -------------- src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)