On 05.02.24 13:48, Aleksander Alekseev wrote:
Hi,

I have found that the files are not listed in the clean target in
src/include/Makefile.  That might explain it, but it's gotta be fixed
anyway.  I'll go ahead with that.

Looks like that made guaibasaurus happy, but I'm still mystified
as to what was wrong and why it didn't repro elsewhere.

I noticed that catalog/syscache_ids.h is not installed when using
Meson. This breaks 3rd party extensions like this:

```
In file included from
/Users/eax/projects/c/timescaledb/tsl/test/src/compression_unit_test.c:19:
/Users/eax/pginstall/include/postgresql/server/utils/syscache.h:23:10:
fatal error: 'catalog/syscache_ids.h' file not found
#include "catalog/syscache_ids.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~
```

It seems to me that include/catalog/meson.build should be modified,
however syscache_info.h *is* installed and I don't see why it would be
processed differently from syscache_ids.h.

The code had this backward accidentally: syscache_ids.h should be installed, but syscache_info.h not. I have fixed this. Thanks.




Reply via email to