pg_upgrade: run all data type checks per connection

The checks for data type usage were each connecting to all databases
in the cluster and running their query. On clusters which have a lot
of databases this can become unnecessarily expensive. This moves the
checks to run in a single connection instead to minimize setup and
teardown overhead.

Reviewed-by: Nathan Bossart <[email protected]>
Reviewed-by: Justin Pryzby <[email protected]>
Reviewed-by: Peter Eisentraut <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/347758b1206364e3bec5ad6cd649b4ba9fe1be7b

Modified Files
--------------
src/bin/pg_upgrade/check.c      | 749 ++++++++++++++++++++++++++--------------
src/bin/pg_upgrade/pg_upgrade.h |  13 +-
src/bin/pg_upgrade/version.c    | 265 +-------------
3 files changed, 506 insertions(+), 521 deletions(-)

Reply via email to