Replace static buf with a stack-allocated one in 'seg' extension The buffer is used only locally within the function. Also, the initialization to '0' characters was unnecessary, the initial content were always overwritten with sprintf(). I don't understand why it was done that way, but it's been like that since forever.
In the passing, change from sprintf() to snprintf(). The buffer was long enough so sprintf() was fine, but this makes it more obvious that there's no risk of a buffer overflow. Reviewed-by: Robert Haas Discussion: https://www.postgresql.org/message-id/7f86e06a-98c5-4ce3-8ec9-3885c8de0...@iki.fi Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/01e51ed78070703c7e078f1519ad59af38e2888a Modified Files -------------- contrib/seg/segparse.y | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)
