Don't advance origin during apply failure. We advance origin progress during abort on successful streaming and application of ROLLBACK in parallel streaming mode. But the origin shouldn't be advanced during an error or unsuccessful apply due to shutdown. Otherwise, it will result in a transaction loss as such a transaction won't be sent again by the server.
Reported-by: Hou Zhijie Author: Hayato Kuroda and Shveta Malik Reviewed-by: Amit Kapila Backpatch-through: 16 Discussion: https://postgr.es/m/tyapr01mb5692fac23be40c69da8ed4aff5...@tyapr01mb5692.jpnprd01.prod.outlook.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b39c5272c1d22d80a736647081b60a55a2d9d51e Modified Files -------------- src/backend/replication/logical/worker.c | 35 ++++++++++++++++++++++++++++++++ src/backend/utils/error/elog.c | 17 ++++++++++++++++ src/include/utils/elog.h | 1 + src/test/subscription/t/021_twophase.pl | 14 ++++++++++++- 4 files changed, 66 insertions(+), 1 deletion(-)
