On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote: > I understand perfectly what the warning is about. > > But the project's perlcritic policy is expressed at src/tools/perlcheck/ > perlcriticrc. It's basically severity 5 plus some additions and one exception. > We shouldn't be imposing our personal perlcritic policies on the project. > > The change isn't bad in itself, but there shouldn't be any expectation that we > will keep to this policy, as it's not required by project policy. > > There is a huge mass of perlcritic issues in our perl code at severity 1 (over > 13000 by my count). If we're going to clean them up (which I would oppose) we > should do it in a systematic way. It's hard to see why this one is special.
I guess it is special only because my policy is more strict so I wanted my new code to match. Should I revert it? Is the very tiny improvement not worth the churn in the code? -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com When a patient asks the doctor, "Am I going to die?", he means "Am I going to die soon?"
