Richard Guo <guofengli...@gmail.com> writes: > This patch can also simplify my other patch, which is to avoid > unnecessary wrapping for plain Vars/PHVs. We can check the new > nullingrel_info to see if the nullingrels of the subquery RTE are a > subset of the nullingrels of the lateral referenced rel, to determine > if the referenced rel is under the same lowest nulling outer join. > And this eliminates the need to introduce lowest_nullable_side.
Right, because that's more or less the same problem. Or indeed it's exactly the same problem, we're just making fast paths for the easiest cases. Another thought: the reason I made get_nullingrels return a new struct rather than tying it directly to filling some fields in pullup_replace_vars_context was that I think we might want to reconsider where to call it from. Perhaps it'd be useful to have the info during is_simple_subquery, for example. regards, tom lane