Improve reporting of pg_upgrade log files on test failure On failure, the pg_upgrade log files are automatically appended to the test log file, but the information reported was inconsistent.
A header, with the log file name, was reported with note(), while the log contents and a footer used print(), making it harder to diagnose failures when these are split into console output and test log file because the pg_upgrade log file path in the header may not be included in the test log file. The output is now consolidated so as the header uses print() rather than note(). An extra note() is added to inform that the contents of a pg_upgrade log file are appended to the test log file. The diffs from the regression test suite and dump files all use print() to show their contents on failure. Author: Joel Jacobson Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/49f7e64a-b9be-4a90-a9fe-210a77404...@app.fastmail.com Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/058b208a5d129dbc1d857338ad68b1fd6613d0e2 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
