cube: pure parser and reentrant scanner Use the flex %option reentrant and the bison option %pure-parser to make the generated scanner and parser pure, reentrant, and thread-safe.
Make the generated scanner use palloc() etc. instead of malloc() etc. Previously, we only used palloc() for the buffer, but flex would still use malloc() for its internal structures. As a result, there could be some small memory leaks in case of uncaught errors. (We do catch normal syntax errors as soft errors.) Now, all the memory is under palloc() control, so there are no more such issues. Simplify flex scan buffer management: Instead of constructing the buffer from pieces and then using yy_scan_buffer(), we can just use yy_scan_string(), which does the same thing internally. (Actually, we use yy_scan_bytes() here because we already have the length.) The previous code was necessary because we allocated the buffer with palloc() and the rest of the state was handled by malloc(). But this is no longer the case; everything is under palloc() now. (We could even get rid of the yylex_destroy() call and just let the memory context cleanup handle everything. But for now, we preserve the existing behavior.) Reviewed-by: Heikki Linnakangas <hlinn...@iki.fi> Reviewed-by: Andreas Karlsson <andr...@proxel.se> Discussion: https://www.postgresql.org/message-id/flat/eb6faeac-2a8a-4b69-9189-c33c520e5...@eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/802fe923e3cd4b2f51080ed1a9a0958024b00479 Modified Files -------------- contrib/cube/cube.c | 7 ++-- contrib/cube/cubedata.h | 15 +++++--- contrib/cube/cubeparse.y | 15 ++++---- contrib/cube/cubescan.l | 89 ++++++++++++++++++++++++++++-------------------- 4 files changed, 74 insertions(+), 52 deletions(-)
