Get rid of old version of BuildTupleHashTable(). It was reasonable to preserve the old API of BuildTupleHashTable() in the back branches, but in HEAD we should actively discourage use of that version. There are no remaining callers in core, so just get rid of it. Then rename BuildTupleHashTableExt() back to BuildTupleHashTable().
While at it, fix up the miserably-poorly-maintained header comment for BuildTupleHashTable[Ext]. It looks like more than one patch in this area has had the opinion that updating comments is beneath them. Discussion: https://postgr.es/m/538343.1734646...@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e0a2721f7c169b50617fed797d7336cd8f10bf77 Modified Files -------------- src/backend/executor/execGrouping.c | 93 +++++++++++-------------------- src/backend/executor/nodeAgg.c | 28 +++++----- src/backend/executor/nodeRecursiveunion.c | 30 +++++----- src/backend/executor/nodeSetOp.c | 30 +++++----- src/backend/executor/nodeSubplan.c | 58 +++++++++---------- src/include/executor/executor.h | 22 +++----- 6 files changed, 115 insertions(+), 146 deletions(-)
