Make verify_compact_attribute available in non-assert builds 6f3820f37 adjusted the assert-enabled validation of the CompactAttribute to call a new external function to perform the validation. That commit made it so the function was only available when building with USE_ASSERT_CHECKING, and because TupleDescCompactAttr() is a static inline function, the call to verify_compact_attribute() was compiled into any extension which uses TupleDescCompactAttr(). This caused issues for such extensions when loading the assert-enabled extension into PostgreSQL versions without asserts enabled due to that function being unavailable in core.
To fix this, make verify_compact_attribute() available unconditionally, but make it do nothing unless building with USE_ASSERT_CHECKING. Author: Andrew Kane <and...@ankane.org> Reviewed-by: David Rowley <dgrowle...@gmail.com> Reviewed-by: Tom Lane <t...@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAOdR5yHfMEMW00XGo=v1zcvus6huq2uehxdvknwtxptczwx...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/34c6e652425fde42c2746f749e31d196fc0d5538 Modified Files -------------- src/backend/access/common/tupdesc.c | 5 ++--- src/include/access/tupdesc.h | 2 -- 2 files changed, 2 insertions(+), 5 deletions(-)
