Repair memory leaks in plpython. PLy_spi_execute_plan (PLyPlan.execute) and PLy_cursor_plan (plpy.cursor) use PLy_output_convert to convert Python values into Datums that can be passed to the query-to-execute. But they failed to pay much attention to its warning that it can leave "cruft generated along the way" behind. Repeated use of these methods can result in a substantial memory leak for the duration of the calling plpython function.
To fix, make a temporary memory context to invoke PLy_output_convert in. This also lets us get rid of the rather fragile code that was here for retail pfree's of the converted Datums. Indeed, we don't need the PLyPlanObject.values field anymore at all, though I left it in place in the back branches in the name of ABI stability. Mat Arye and Tom Lane, per report from Mat Arye. Back-patch to all supported branches. Discussion: https://postgr.es/m/cadsur0dvvgnzywwnmkrk65mzg7ylustdlv61qdnrwtrajgu...@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/02a38bc84befa2858fbff65fd9cb46b640d5abd2 Modified Files -------------- src/pl/plpython/plpy_cursorobject.c | 52 +++++++++++++++------------------ src/pl/plpython/plpy_spi.c | 58 ++++++++++++++++--------------------- 2 files changed, 49 insertions(+), 61 deletions(-)
