Fix catcache invalidation of a list entry that's being built

If a new catalog tuple is inserted that belongs to a catcache list
entry, and cache invalidation happens while the list entry is being
built, the list entry might miss the newly inserted tuple.

To fix, change the way we detect concurrent invalidations while a
catcache entry is being built. Keep a stack of entries that are being
built, and apply cache invalidation to those entries in addition to
the real catcache entries. This is similar to the in-progress list in
relcache.c.

Back-patch to all supported versions.

Reviewed-by: Noah Misch
Discussion: 
https://www.postgresql.org/message-id/2234dc98-06fe-42ed-b5db-ac17384dc...@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/af8cd1639ab298ba8fae62cd9583f1c10a5068e1

Modified Files
--------------
src/backend/utils/cache/catcache.c                 | 232 +++++++++++++--------
src/backend/utils/cache/inval.c                    |   2 +-
src/include/utils/catcache.h                       |   1 +
src/test/modules/test_misc/meson.build             |   1 +
src/test/modules/test_misc/t/007_catcache_inval.pl |  98 +++++++++
src/tools/pgindent/typedefs.list                   |   1 +
6 files changed, 252 insertions(+), 83 deletions(-)

Reply via email to