At update of non-LP_NORMAL TID, fail instead of corrupting page header. The right mix of DDL and VACUUM could corrupt a catalog page header such that PageIsVerified() durably fails, requiring a restore from backup. This affects only catalogs that both have a syscache and have DDL code that uses syscache tuples to construct updates. One of the test permutations shows a variant not yet fixed.
This makes !TransactionIdIsValid(TM_FailureData.xmax) possible with TM_Deleted. I think core and PGXN are indifferent to that. Per bug #17821 from Alexander Lakhin. Back-patch to v13 (all supported versions). The test case is v17+, since it uses INJECTION_POINT. Discussion: https://postgr.es/m/17821-dd8c334263399...@postgresql.org Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f4af4515bb5f3591d49bc16b6cb8ddbf66f98374 Modified Files -------------- src/backend/access/heap/heapam.c | 49 +++++- src/backend/utils/cache/inval.c | 3 + src/include/access/tableam.h | 3 +- src/test/modules/injection_points/Makefile | 9 +- .../expected/syscache-update-pruned.out | 87 ++++++++++ .../expected/syscache-update-pruned_1.out | 86 ++++++++++ .../injection_points/injection_points--1.0.sql | 8 + src/test/modules/injection_points/meson.build | 4 +- .../modules/injection_points/regress_injection.c | 71 ++++++++ .../specs/syscache-update-pruned.spec | 179 +++++++++++++++++++++ 10 files changed, 493 insertions(+), 6 deletions(-)
